[metrics] track tx lifecycle time #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlawt
changed the title
wlawt
commented
Sep 8, 2025
wlawt
commented
Sep 8, 2025
danyalprout
reviewed
Sep 8, 2025
Collaborator
danyalprout
left a comment
danyalprout
left a comment
There was a problem hiding this comment.
Looks great, left a few comments. Can we also downgrade all logs to debug from info. Thanks
wlawt
changed the title
wlawt
changed the title
wlawt
force-pushed
the
tx-tracing
branch
2 times, most recently
from
8929090 to
4e2af78
Compare
danyalprout
reviewed
Sep 9, 2025
danyalprout
approved these changes
Sep 9, 2025
danyalprout
reviewed
Sep 9, 2025
0xsimulacra
pushed a commit
to 0xsimulacra/base-node-reth
that referenced
this pull request
Oct 1, 2025
* wip exex * first pass * remove readme * track num dropped/replaced * update toml structure * naming * nits * use lru over hashmap * record metrics * always install exex * fix ci * combine inclusion and event fn together * use install if * fix ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an ExEx to track the lifecycle of a transaction.
Specifically, it tracks the time to inclusion when a transaction is first detected in the mempool to when it's included in a block. It also tracks the number of transactions that are dropped/replaced. These are recorded as Histogram metrics.
TODO: