Draft
Conversation
philipp94831
commented
Feb 26, 2026
...ams-bootstrap-core/src/main/java/com/bakdata/kafka/consumerproducer/ConsumerProducerApp.java
Outdated
Show resolved
Hide resolved
philipp94831
commented
Feb 26, 2026
| log.debug("Closing consumer runnable"); | ||
| this.consumerRunnable.close(); | ||
| } catch (final RuntimeException e) { | ||
| //TODO why catch? |
| log.debug("Closing producer"); | ||
| this.producer.close(); | ||
| } catch (final RuntimeException e) { | ||
| //TODO why catch? |
| } catch (final WakeupException exception) { | ||
| log.info("Consumer poll loop waking up for shutdown", exception); | ||
| } catch (final RuntimeException exception) { | ||
| //TODO why catch? |
philipp94831
commented
Feb 26, 2026
| .config(this.config) | ||
| .build(); | ||
| log.debug("Calling start hook"); | ||
| this.executionOptions.onStart(runningConsumer); |
Member
Author
There was a problem hiding this comment.
@raphala @jkbe Do we even need that? I don't think so. For streams it exists to give the use access to the KafkaStreams instance for building application servers. For the consumer and consumer-producer, the user already has full control because the user implements the complete runnable. I would remove it tbh
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #385 and #387