Feature/use select list #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This currently also adds the |
Contributor
Author
|
Uuuhm, yes that was inteded for testing. But shouldn't matter once #29 was merged. 🤞 |
Member
Contributor
Author
|
I reckon yes. |
ochorocho
added a commit
that referenced
this pull request
May 5, 2022
…typing the extension key manually.
ochorocho
force-pushed
the
feature/use-select-list
branch
from
e864526 to
c3fe702
Compare
Contributor
Author
|
This MR does no longer depend on #29 |
o-ba
requested changes
May 9, 2022
* Remove duplicated code * change typing as resolvePackage() can be null * store PageResolver instance in local var
o-ba
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use select list for all commands