fix: update apache airflow and update test requirements by mufaddal-rohawala · Pull Request #3855 · aws/sagemaker-python-sdk

mufaddal-rohawala · 2023-05-12T19:15:35Z

Issue #, if available:

Description of changes:

Updating airflow to 2.6.0
Moving relevant local and scipy requirements in test requirements. Skipping docker compose due to conflicts with airflow and also pypi seems to be an unsupported distribution partner for latest docker compose releases. We install docker compose in our infra image directly.

The conflict is caused by:
    sagemaker[test] 2.154.1.dev0 depends on jsonschema
    apache-airflow 2.6.0 depends on jsonschema>=4.0.0
    docker-compose 1.29.2 depends on jsonschema<4 and >=2.5.1

Testing done:

Tested package resolution locally.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-05-12T19:58:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9dba4d0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-12T20:11:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9dba4d0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-12T20:11:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9dba4d0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-12T20:22:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9dba4d0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-12T20:23:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9dba4d0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-12T20:45:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 9dba4d0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-05-12T20:45:59Z

Codecov Report

Merging #3855 (9dba4d0) into master (fd90b1d) will decrease coverage by 0.72%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3855      +/-   ##
==========================================
- Coverage   89.96%   89.25%   -0.72%     
==========================================
  Files        1140      267     -873     
  Lines      105300    26025   -79275     
==========================================
- Hits        94733    23228   -71505     
+ Misses      10567     2797    -7770

Impacted Files	Coverage Δ
...agemaker/serverless/serverless_inference_config.py	`100.00% <100.00%> (ø)`

... and 1406 files with indirect coverage changes

sagemaker-bot · 2023-05-12T21:15:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9dba4d0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure

/bot run pr

sagemaker-bot · 2023-05-16T02:00:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9dba4d0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-16T02:03:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9dba4d0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-16T02:42:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 9dba4d0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-16T17:51:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 9dba4d0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-16T19:51:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2585bec
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-16T19:54:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 2585bec
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-16T19:59:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 2585bec
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-16T20:09:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2585bec
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-16T21:59:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 2585bec
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala requested a review from a team as a code owner May 12, 2023 19:15

mufaddal-rohawala requested review from claytonparnell and removed request for a team May 12, 2023 19:15

knikure self-requested a review May 15, 2023 19:02

knikure self-assigned this May 15, 2023

knikure removed the request for review from claytonparnell May 15, 2023 19:02

knikure linked an issue May 15, 2023 that may be closed by this pull request

Docker Compose V2 compatibility for local mode #3659

Closed

knikure reviewed May 16, 2023

View reviewed changes

knikure mentioned this pull request May 16, 2023

build(deps): bump apache-airflow from 2.5.1 to 2.6.0 in /requirements/extras #3842

Closed

update apache airflow and update test requirements

2585bec

knikure force-pushed the fix-dependebot-airflow branch from 9dba4d0 to 2585bec Compare May 16, 2023 18:58

knikure merged commit 1fe8619 into aws:master May 16, 2023

pdifranc mentioned this pull request May 17, 2023

Docker Compose V2 compatibility for local mode #3659

Closed

Conversation

mufaddal-rohawala commented May 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented May 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

Uh oh!

knikure left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented May 16, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 16, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 16, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 16, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 16, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 16, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 16, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 16, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 16, 2023

AWS CodeBuild CI Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mufaddal-rohawala commented May 12, 2023 •

edited

Loading

codecov-commenter commented May 12, 2023 •

edited

Loading

knikure left a comment •

edited

Loading