breaking: deprecate unused parameters by chuyang-deng · Pull Request #1743 · aws/sagemaker-python-sdk

chuyang-deng · 2020-07-23T00:35:32Z

Issue #, if available:
#1475

Description of changes:
Deprecate unused framework parameters and delete corresponding docs, tests.

Testing done:
unit tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2020-07-23T00:43:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a65f8c5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-23T01:03:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a65f8c5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-23T01:16:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a65f8c5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-23T02:20:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: a65f8c5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-23T06:04:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b8dcc99
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-23T06:24:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b8dcc99
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-23T06:28:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: b8dcc99
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-23T06:38:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b8dcc99
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

laurenyu · 2020-07-23T15:23:10Z

src/sagemaker/amazon/kmeans.py

    )
    epochs = hp("epochs", gt(0), "An integer greater-than 0", int)
    center_factor = hp("extra_center_factor", gt(0), "An integer greater-than 0", int)
-    eval_metrics = hp(


I remember doing some more digging back during #1480 - https://docs.aws.amazon.com/sagemaker/latest/dg/k-means-api-config.html seems to contradict the internal backlog item we had, so let's keep eval_metrics in KMeans and RCF

sagemaker-bot · 2020-07-23T16:11:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d857533
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

laurenyu · 2020-07-23T16:24:32Z

tests/unit/test_linear_learner.py



-@pytest.mark.parametrize("iterable_hyper_parameters, value", [("eval_metrics", 0)])
+@pytest.mark.parametrize("iterable_hyper_parameters, value", [("max_iterations", [0])])


was this test not working before?

It was working before. The test expects throwing a TypeError that eval_metrics should be a list instead of an integer.

sagemaker-bot · 2020-07-23T16:29:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d857533
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-23T16:44:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d857533
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-23T17:57:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: d857533
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-23T18:25:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f1441e0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-23T18:43:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f1441e0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-23T18:51:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: f1441e0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-23T19:00:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f1441e0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-23T19:49:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f1441e0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-24T16:19:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 53516fa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-24T16:42:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 53516fa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-24T16:53:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 53516fa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-24T16:58:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 53516fa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

change: deprecate unused parameters

a65f8c5

remove eval_metrics from randomcutforest integ test

b8dcc99

chuyang-deng changed the title ~~change: deprecate unused parameters~~ breaking: deprecate unused parameters Jul 23, 2020

laurenyu reviewed Jul 23, 2020

View reviewed changes

recover eval_metrics for kmeans and rcf

d857533

laurenyu reviewed Jul 23, 2020

View reviewed changes

Merge branch 'zwei' into deprecate-unused-params

f1441e0

Merge branch 'zwei' into deprecate-unused-params

53516fa

laurenyu approved these changes Jul 24, 2020

View reviewed changes

chuyang-deng merged commit 0a5b863 into aws:zwei Jul 24, 2020

chuyang-deng deleted the deprecate-unused-params branch July 24, 2020 17:31



		@pytest.mark.parametrize("iterable_hyper_parameters, value", [("eval_metrics", 0)])
		@pytest.mark.parametrize("iterable_hyper_parameters, value", [("max_iterations", [0])])

Conversation

chuyang-deng commented Jul 23, 2020

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jul 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 23, 2020

AWS CodeBuild CI Report

Uh oh!

laurenyu Jul 23, 2020

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jul 23, 2020

AWS CodeBuild CI Report

Uh oh!

laurenyu Jul 23, 2020

Choose a reason for hiding this comment

Uh oh!

chuyang-deng Jul 24, 2020

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jul 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 23, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 24, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 24, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 24, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 24, 2020

AWS CodeBuild CI Report

Uh oh!

Reviewers

Assignees