Reinvent Keynote3 Elastic Training Feature Support#341
Merged
mollyheamazon merged 6 commits intomainfrom Dec 3, 2025
Merged
Conversation
Co-authored-by: Mohamed Zeidan <zeidmo@amazon.com>
Co-authored-by: Mohamed Zeidan <zeidmo@amazon.com>
* feat: Implement elastic training cli arguments (#273) * feat: Implement elastic training cli arguments * Add elastic training unified config and unit test * Add graceful shutdown and scaling timeout to cli args * Revert "feat: Implement elastic training cli arguments (#273)" This reverts commit 18428ef. * feat: Implement elastic training cli arguments (#295) * feat: implement elastic training cli args * Rename args name to match crd for elastic training * Add unit test for replcia discrete values * Add integ test for elastic training cli --------- Co-authored-by: Sophia <yungwenh@amazon.com> Co-authored-by: Molly He <mollyhe@amazon.com> Co-authored-by: Mohamed Zeidan <zeidmo@amazon.com>
mohamedzeidan2021
approved these changes
Dec 3, 2025
aviruthen
approved these changes
Dec 3, 2025
nargokul
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing and why?
We are adding six new command line arguments related to elastic training for HyperPodTrainingOperator. Elastic training is a method that dynamically scales distributed machine learning operations, which helps solve the resource inefficiency or poor fault tolerance issues being seen often in traditional distributed training jobs.
Before/After UX
Before:
hyp create hyp-pytorch-job
--job-name <job_name>
--image <image_name>
--node-count 1
After:
(Case 1)
hyp create hyp-pytorch-job
--job-name <job_name>
--image <image_name>
--node-count 1
--elastic-replica-increment-step 1
--max-node-count 2
--elastic-graceful-shutdown-timeout-in-seconds 180
--elastic-scaling-timeout-in-seconds 60
--elastic-scale-up-snooze-time-in-seconds 60
(Case 2)
hyp create hyp-pytorch-job
--job-name <job_name>
--image <image_name>
--node-count 1
--max-node-count 8
--elastic-graceful-shutdown-timeout-in-seconds 180
--elastic-scaling-timeout-in-seconds 60
--elastic-scale-up-snooze-time-in-seconds 60
--elastic-replica-discrete-values '[2, 4, 8]'
How was this change tested?
Are unit tests added?
Yes
Are integration tests added?
Yes
Reviewer Guidelines
One of the following must be true: