Refactor canary auto-generation cli semantics#1085
Merged
marc-1010 merged 1 commit intoaws-cloudformation:masterfrom Aug 21, 2024
Merged
Refactor canary auto-generation cli semantics#1085marc-1010 merged 1 commit intoaws-cloudformation:masterfrom
marc-1010 merged 1 commit intoaws-cloudformation:masterfrom
Conversation
ammokhov
reviewed
Jul 30, 2024
Contributor
ammokhov
left a comment
There was a problem hiding this comment.
I am confused what benefits we get from having local-code-generation
Contributor
Author
There is no valid use case/need for re-generating canary code during remote builds. Canaries are not assumed to be a build time generated-source. This cli argument will prevent remote builds from re-generation/overriding canary code during remote host build time. I don't think the burden should be on providers to manually to disable canary generation completely in .rpdk-config to prevent behavior that is unnecessary. |
agarikana
approved these changes
Aug 13, 2024
AidenAtSea
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
.rpdk-configwhen providers are upgrading their rpdk version set.local-code-generationto thecfn generatecommand to enable canary auto generation. This intended to restrict canary autogeneration to specific development use cases. Canary auto-generation should not occur for remote builds.Unit Test Cases:
local-code-generationflag is missing or False.local-code-generation=Trueto existing unit testsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.