Customize management api token provider #748
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Support for TokenProvider in Builder:
Added a new static method: newBuilder(String domain, TokenProvider tokenProvider), allowing the creation of a ManagementAPI.Builder using a TokenProvider instead of a raw API token.
Updated the Builder class to accept either an API token (wrapped in a SimpleTokenProvider) or a TokenProvider directly.
The builder now stores a TokenProvider instead of a raw API token.
The build() method now uses the provided TokenProvider directly, instead of always wrapping an API token.
API Token Handling:
The constructor Builder(String domain, String apiToken) now delegates to Builder(String domain, TokenProvider tokenProvider) by wrapping the token in a SimpleTokenProvider.
Credits
Thanks @krrrr38 for raising #729.
References
Please include relevant links supporting this change such as a:
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist