Unstaged changes view pops up unexpectedly when switching panes

[maxbrunsfeld]

Description

Sometimes, when changing focus from a diff view in one pane to a text editor in another pane, another diff view unexpectedly pops up.

Steps to Reproduce

1. Add multiple project folders, each of which are a git repository (say atom and github).
2. Open a diff view for a file in the atom repository.
3. Change focus to another pane in which a file from github is open.
4. A diff view for the first modified file in the github repository opens unexpectedly.

Expected behavior:

It seems like diff views should only open when I directly perform some action in the commit panel. They shouldn't open in response to other unrelated events like changing focus to a text editor.

Actual behavior:

Diff views spontaneously open when changing focus to a pane containing a text editor.

Reproduces how often:

Unfortunately, this seems to depend on some sequence of events that I don't fully understand. I can't always get it to happen.

Versions

Atom    : 1.25.0-dev-3d8902d52
Electron: 1.7.10
Chrome  : 58.0.3029.110
Node    : 7.9.0

[Ben3eeE]

[maxbrunsfeld]

I'm still seeing a similar bug after building atom/atom@7dfb45e.

Repro:

1. Enable the Allow Pending Pane Items setting.
2. Open the atom repo in Atom with no outstanding changes.
3. Open the file package.json
4. Make a one-line change such as inserting a newline at the top of the file.
5. Open the Git panel
6. Click on package.json in the Unstaged Changed section.
7. There should now be two tabs: the package.json editor and the Unstaged Changes view, which should be focused.
8. Click on the first tab (the package.json editor).

Expected behavior

The package.json editor becomes the active item.

Actual behavior

The package.json editor momentarily becomes active, but then the Unstaged Changes view immediately becomes active again.

[maxbrunsfeld]

I tried to record a GIF, but when I click the editor tab, focus switches back to the diff tab so quickly that you can't even see it.

[Ben3eeE]

The comments by @maxbrunsfeld here is the same issue as #1444 (comment)

[smashwilson]

Closing this because #1488 should deal with it Once And For All ™️. Re-open at will if you see this pop up with atom/github >= 0.15.2.