Skip to content

generic accessibility issue :-in pop up box when we are navigating th… checkin on behalf of harneet #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
assureclaims merged 1 commit into from
Mar 28, 2023
Merged

generic accessibility issue :-in pop up box when we are navigating th… checkin on behalf of harneet #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions projects/dxc-ngx-cdk/src/lib/dxc-dialog/dxc-dialog.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
<div class="backOverlay" role="overlay" (click)="onBackgroundClickHandler($event)" [class.backVisible]="overlay">
</div>
<div [ngClass]="'container p-0 mw-100 mph-' + height + ' mpw-'+ width">
<div class="dialogContainer h-100 w-100" tabindex="-1" #dialogboxstart>
<div class="dialogContainer h-100 w-100" tabindex="0" role="dialog" (keydown)="startKeyPress($event)" [attr.aria-label]="ariaLabel"
[attr.aria-labelledby]="ariaLabelledBy" [attr.aria-describedby]="ariaDescribedBy" #dialogboxstart>
<div #dialogHeader [style.height.px]="headerHeight" class="dialog-header d-flex align-items-center justify-content-between px-2">
<span>
<ng-content select="dxc-dialog-header"></ng-content>
Expand All @@ -18,8 +19,7 @@
</a>
</span>
</div>
<div class="content" tabindex="0" role="dialog" (keydown)="startKeyPress($event)" [attr.aria-label]="ariaLabel"
[attr.aria-labelledby]="ariaLabelledBy" [attr.aria-describedby]="ariaDescribedBy">
<div class="content">
<ng-content select="dxc-dialog-body"></ng-content>
<span #dialogboxreturn tabindex="-1" (onblur)="returnFocusOut($event)"></span>
<span #dialogboxend tabindex="0" (focus)="endFocus($event)"></span>
Expand Down
4 changes: 3 additions & 1 deletion projects/dxc-ngx-cdk/src/lib/dxc-dialog/dxc-dialog.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,10 @@ export class DxcDialogComponent implements OnDestroy, AfterViewInit {
}

endFocus($event: any) {
if (this.dialogboxstart.nativeElement.focus)
if (this.dialogboxstart.nativeElement.focus){
this.dialogboxstart.nativeElement.tabindex = "0";
this.dialogboxstart.nativeElement.focus();
}
}

returnFocusOut($event: any) {
Expand Down