Add select for SDK source#21
Merged
nathaniel-furniss-glean merged 2 commits intomainfrom Aug 12, 2025
Merged
Conversation
nathaniel-furniss-glean
requested review from
naveen-ls-glean,
taozhou-glean and
vardhman-singh-glean
taozhou-glean
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typos when changing the source are an easy source of silly errors.
Added a
<select>to choose Canary or Local. Displays "Custom" if the SDK source option is edited directly (for example, if local glean is not running on port 8888), but Custom is not user selectable. Current source still shown via hover over "current sdk source:" (though this is not obvious and can be improved later)Screenshots