Skip to content

Conversation

@ascopes
Copy link
Owner

@ascopes ascopes commented Dec 15, 2024

Removes JPMS descriptors from unit tests as a form of simplification.

A couple of test cases become irrelevant or untestable with this change, so have been removed.

@ascopes ascopes added the testing Improvements to test packs label Dec 15, 2024
@ascopes ascopes self-assigned this Dec 15, 2024
@ascopes ascopes force-pushed the task/remove-jpms-from-unit-tests branch 2 times, most recently from 521638b to 83a21bc Compare December 15, 2024 10:54
@codecov
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.21%. Comparing base (d607b76) to head (f44f8ed).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
- Coverage   87.65%   87.21%   -0.44%     
==========================================
  Files          99       99              
  Lines        2948     2942       -6     
  Branches      229      229              
==========================================
- Hits         2584     2566      -18     
- Misses        316      329      +13     
+ Partials       48       47       -1     
Files with missing lines Coverage Δ
...b/ascopes/jct/junit/AbstractCompilersProvider.java 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@ascopes ascopes force-pushed the task/remove-jpms-from-unit-tests branch from a8881bb to f44f8ed Compare December 15, 2024 11:17
@ascopes ascopes merged commit 770e2f7 into main Dec 15, 2024
19 of 20 checks passed
@ascopes ascopes deleted the task/remove-jpms-from-unit-tests branch December 15, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Improvements to test packs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants