fix: Update aria-labels for social icons in footer#348
Merged
TGlide merged 2 commits intoappwrite:mainfrom Dec 18, 2023
guptadeepak8:fix-aria-labels-for-social-icons
Merged
fix: Update aria-labels for social icons in footer#348TGlide merged 2 commits intoappwrite:mainfrom guptadeepak8:fix-aria-labels-for-social-icons
TGlide merged 2 commits intoappwrite:mainfrom
guptadeepak8:fix-aria-labels-for-social-icons
Conversation
|
@guptadeepak8 is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Hi @guptadeepak8 thanks for the PR, but this issue is being worked on by @jasonetorres. |
Contributor
Author
|
@Haimantika Thankyou for letting me know ,i noticed the delay in progress, so I decided to submit the PR. " |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This update fixes a labeling issue with social icons in the footer. Changed from "Appwrite on [social]" to just the social platform name (e.g., "Linkedin"). Improves accessibility for users using assistive tech.
Test Plan
NA
Related PRs and Issues
Issue #281
Have you read the Contributing Guidelines on issues?
yes