ADFA-2688: add missing FOREGROUND_SERVICE_DATA_SYNC permission

[itsaky-adfa]

See ADFA-2688 for more details.

Fixes #894

[coderabbitai]

📝 Walkthrough

Release Notes

• Added missing FOREGROUND_SERVICE_DATA_SYNC permission to the logsender module's AndroidManifest.xml to comply with Android 14 (SDK 34) requirements for foreground services
• Fixes SecurityException that was causing the app to force close when activating the "Log Sender" feature (LogSenderService) in debug mode on Android 14 devices
• Minimal, targeted change with only one permission addition to enable data synchronization for foreground service operations (the service type was already declared as dataSync)
• No risks or best practices violations: This change is required and follows Google's Android security model for foreground services with specific types (introduced in Android 12/API 31)

Walkthrough

Added the android.permission.FOREGROUND_SERVICE_DATA_SYNC permission to the logsender module's AndroidManifest.xml to resolve SecurityException crashes on Android 14+ when the LogSenderService attempts to start as a foreground service with dataSync type.

Changes

Cohort / File(s)	Summary
LogSender Manifest Permission logsender/src/main/AndroidManifest.xml	Added android.permission.FOREGROUND_SERVICE_DATA_SYNC permission declaration to satisfy Android 14+ foreground service requirements for data synchronization operations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A tiny thread in manifest's weave,
One permission to help logs breathe,
No more crashes in Android's arms,
The LogSender's granted its charms! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The PR adds FOREGROUND_SERVICE_DATA_SYNC permission as required by issue #894, but does not add FOREGROUND_SERVICE permission, and does not address the optional suggestion for a warning.	Add android.permission.FOREGROUND_SERVICE permission alongside FOREGROUND_SERVICE_DATA_SYNC to fully meet the requirements in issue #894.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely describes the primary change: adding the FOREGROUND_SERVICE_DATA_SYNC permission to AndroidManifest.xml.
Description check	✅ Passed	The description references the linked issue ADFA-2688 and mentions fixing issue #894, which is directly related to the changeset of adding the permission.
Out of Scope Changes check	✅ Passed	The PR only adds the required permission to AndroidManifest.xml, which is directly in scope with the linked issue objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}