Skip to content

ADFA-2542 Change preference gradle offline default from true to false #877

Merged
hal-eisen-adfa merged 1 commit intostagefrom
ADFA-2542-Default-to-online-mode-for-Gradle
Jan 23, 2026
Merged

ADFA-2542 Change preference gradle offline default from true to false #877
hal-eisen-adfa merged 1 commit intostagefrom
ADFA-2542-Default-to-online-mode-for-Gradle

Conversation

@hal-eisen-adfa
Copy link
Collaborator

@hal-eisen-adfa hal-eisen-adfa commented Jan 23, 2026

We need this to encourage user retention during Phase 1 and Phase 2; this will be reverted when we shift to Phase 3 (the 2 billion people lacking low cost high speed internet)
We see requests for this in Telegram often

…ase 1 and Phase 2; this will be reverted when we shift to Phase 3
@hal-eisen-adfa hal-eisen-adfa requested a review from a team January 23, 2026 21:18
Copy link
Contributor

@Daniel-ADFA Daniel-ADFA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 23, 2026

📝 Walkthrough

Walkthrough

The default value for offline mode in BuildPreferences has been changed from enabled (true) to disabled (false). This affects the initial state when the OFFLINE_MODE preference has not yet been explicitly set by the user.

Changes

Cohort / File(s) Summary
Offline Mode Configuration
preferences/src/main/java/com/itsaky/androidide/preferences/internal/BuildPreferences.kt
Modified isOfflineEnabled property getter: default value changed from true to false for OFFLINE_MODE preference. When preference is unset, offline mode now defaults to disabled.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A preference shift so small, yet it matters most,
From offline to online, the default shall roast,
False becomes the new truth, as the bunnies declare,
Mode toggled with grace, in the code's gentle care!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description is related to the changeset, explaining the business rationale for changing the offline mode default and its intended impact on user retention.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: switching the Gradle offline mode default from true to false in the BuildPreferences file.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hal-eisen-adfa hal-eisen-adfa changed the title Change preference gradle offline default from true to false ADFA-2542 Change preference gradle offline default from true to false Jan 23, 2026
@hal-eisen-adfa hal-eisen-adfa merged commit 755cb5e into stage Jan 23, 2026
2 checks passed
@hal-eisen-adfa hal-eisen-adfa deleted the ADFA-2542-Default-to-online-mode-for-Gradle branch January 23, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants