fix for generate debug assets out of memory error

[jomen-adfa]

Fixes the out of memory error that curl encounters when uploading ~1Gb assets zips files to Google Drive

[coderabbitai]

📝 Walkthrough

• Fixed out-of-memory error when uploading large (~1GB) asset zip files to Google Drive by switching curl file upload option from --data-binary @"${PATH}" to --upload-file "${PATH}" in the workflow step that uploads V8 and V7 asset zips.
• Updated asset upload commands in .github/workflows/generate_assets.yml:
  • V8 upload now uses --upload-file "${V8_PATH}"
  • V7 upload now uses --upload-file "${V7_PATH}"
• Technical benefit: --upload-file streams the file from disk instead of loading it entirely into memory, preventing curl from exhausting RAM on large uploads.
• Scope: change is limited to the curl upload flag (lines changed +2/-2); no other logic, error handling, authentication, or asset-generation steps were modified.

Risks & Notes:

• ⚠️ Compatibility check recommended: the workflow uses -X PATCH with --upload-file. curl’s --upload-file typically issues PUT semantics; verify the Google Drive upload endpoint supports PATCH with this flag in production testing.
• No changes were made to HTTP status handling or workflow success/failure logic beyond the upload flag swap.

Walkthrough

GitHub Actions workflow updated: curl upload option changed from --data-binary to --upload-file for V8 and V7 asset uploads. No other logic or error handling modified.

Changes

Cohort / File(s)	Summary
CI/CD Workflow Configuration ​.github/workflows/generate_assets.yml	Replaced --data-binary @"${V8_PATH}" with --upload-file @"${V8_PATH}" and --data-binary @"${V7_PATH}" with --upload-file @"${V7_PATH}" for asset uploads.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

• Daniel-ADFA
• hal-eisen-adfa

Poem

🐰 I hopped through YAML, light and spry,
Swapped a flag in curl—no tear nor cry,
Binary's old path now sings anew,
Assets glide up smooth, in morning dew. 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: fixing an out of memory error related to generating debug assets.
Description check	✅ Passed	The description is directly related to the changeset, explaining the problem being solved (out of memory error with large asset uploads).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.github/workflows/generate_assets.yml (1)

185-202: Remove @ prefix from --upload-file arguments to fix upload failures.

The @ prefix is not supported by --upload-file; it's only valid for --data and --form options. curl will attempt to open a literal filename starting with @, causing the uploads to fail.

Fix

-            --upload-file @"${V8_PATH}" \
+            --upload-file "${V8_PATH}" \
...
-            --upload-file @"${V7_PATH}" \
+            --upload-file "${V7_PATH}" \