ADFA-2501 Fix dependency on bundlePluginArtifactsForRelease

[hal-eisen-adfa]

No description provided.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Release Notes

• Added conditional dependency on bundlePluginArtifactsForRelease task: Release-variant lint tasks for V8 and V7 architectures now depend on the bundlePluginArtifactsForRelease task when their name contains "release", ensuring plugin artifacts are bundled before these lint checks run.

• Applies to V8 lint tasks: Any lint task with "V8" in its name and "release" in its name will now wait for plugin artifact bundling to complete.

• Applies to V7 lint tasks: Any lint task with "V7" in its name and "release" in its name will now wait for plugin artifact bundling to complete.

Risks & Best Practice Violations

• ⚠️ Anti-pattern: Heavy dependencies on lint tasks: Adding asset bundling dependencies to lint tasks violates the principle of task separation. Lint tasks should be lightweight and independent. This could cause unintended side effects when running lint-only builds for release variants.

• ⚠️ Build performance impact: Lint tasks will now trigger full asset bundling operations, which may significantly slow down release build verification and CI/CD pipelines that run lint checks.

• ⚠️ Potential circular dependency risk: If any linting is performed before the release assembly phase, this could introduce unexpected build ordering issues.

• ⚠️ Inconsistent with non-release builds: Debug-variant lint tasks do not have this dependency, creating inconsistency in build behavior between debug and release configurations.

Walkthrough

Modified app/build.gradle.kts to add a conditional dependency: lint tasks for V8/V7 variants now depend on bundlePluginArtifactsForRelease when the task name also contains "release", affecting release build configurations only.

Changes

Cohort / File(s)	Change Summary
Build Configuration app/build.gradle.kts	Added conditional dependency on bundlePluginArtifactsForRelease to lint tasks that match V8/V7 and contain "release" in task name

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• ADFA-2496: fix: resolve Gradle implicit dependency validation for lint tasks #789: Similarly modifies app/build.gradle.kts afterEvaluate block to add conditional dependencies for V8/V7 lint tasks, though targeting bundleLlamaAssets instead of bundlePluginArtifactsForRelease.

Suggested reviewers

• jatezzz
• jomen-adfa

Poem

🐰 Hop, hop! Build tasks now align,
Release lint runs with bundles so fine,
V8 and V7 paths intertwine,
Gradle magic—a carrot-sized design! ✨

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 163acd5 and 2762186.

📒 Files selected for processing (1)

• app/build.gradle.kts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}