ADFA-2497 Remove scp to GreenGeeks

[hal-eisen-adfa]

GreenGeeks has a secret disk storage limit so we need to stop storing release apk files there

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Release Notes

• Removed SCP upload step to GreenGeeks: The "Upload APK to server" step that transferred release APK files to the GreenGeeks server has been removed from the CI/CD pipeline.
• Resolves GreenGeeks storage limitation: This change stops consuming GreenGeeks' limited disk storage for release builds, as mentioned in the ticket (ADFA-2497).
• Firebase App Distribution remains: Release APKs continue to be deployed to Firebase App Distribution without disruption.

Risks & Best Practices Violations

⚠️ Potential orphaned SSH configuration: The workflow still contains SSH key setup and configuration for GreenGeeks (lines 168-221 and 585-638) and corresponding cleanup steps. Since the SCP upload step has been removed, the SSH setup appears to be unused and should be removed in a follow-up cleanup to:

• Reduce build step complexity
• Improve build time by eliminating unnecessary SSH operations
• Reduce the attack surface by not setting up credentials that aren't used
• Follow the principle of removing code that no longer serves a purpose

⚠️ Incomplete refactoring: For a complete removal of GreenGeeks integration, consider removing the SSH setup and cleanup steps in a subsequent PR to fully decouple the workflow from the GreenGeeks infrastructure.

Walkthrough

The "Upload APK to server" step was removed from the release workflow, eliminating APK upload validation and SCP transfer logic. Associated environment variable checks and server upload command were also removed. A minor trailing newline formatting adjustment was applied.

Changes

Cohort / File(s)	Change Summary
Workflow Deployment Step Removal .github/workflows/release.yml	Removed "Upload APK to server" step including APK_PATH, GREENGEEKS_HOST, and GREENGEEKS_USER variable validation and SCP upload command. Minor trailing newline formatting adjustment at end of file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

• Daniel-ADFA

Poem

🐰 A step removed, so clean and bright,
No more uploads in the night,
Workflows streamlined, workflows lean,
The cleanest release workflow seen! ✨

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 91545e8 and a7b60c8.

📒 Files selected for processing (1)

• .github/workflows/release.yml

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}