fix: resolve Gradle configuration cache incompatibility in PluginBuilder

[Daniel-ADFA]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PluginBuilder.kt file underwent refactoring to improve variable scope and logging context. Top-level local variables now compute pluginName, apkDir, and outputDir outside inner task execution blocks, and logging switched from project-scoped to task-scoped logger for APK lookup and assembly operations. Redundant variable re-declarations within the execute block were removed.

Changes

Cohort / File(s)	Summary
PluginBuilder Refactoring plugin-api/plugin-builder/src/main/kotlin/com/itsaky/androidide/plugins/build/PluginBuilder.kt	Moved variable declarations (pluginName, apkDir, outputDir) to outer scope in createDebugTask and createReleaseTask methods; switched logging context from project.logger to task.logger for APK operations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• ADFA-2508: Add PluginBuilder Gradle plugin for .cgp file generation #805: Modifies the same PluginBuilder.kt logic for assemblePlugin/assemblePluginDebug task creation with related scope and logging refactoring patterns.

Suggested reviewers

• jomen-adfa

Poem

🐰 Variables hop to outer scopes so clean,
Task loggers whisper where project ones had been,
Redundant declarations bid farewell with grace,
Cleaner code now fills this refactored space! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess whether the description relates to the changeset.	Add a description explaining the Gradle configuration cache incompatibility issue, why it occurs, and how the variable scope changes resolve it.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix: resolve Gradle configuration cache incompatibility in PluginBuilder' accurately describes the main change: refactoring PluginBuilder to fix Gradle configuration cache incompatibility by moving variable declarations outside inner task blocks and using task-scoped loggers.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ADFA-3110-plugin-template-fails-to-build

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@plugin-api/plugin-builder/src/main/kotlin/com/itsaky/androidide/plugins/build/PluginBuilder.kt`:
- Around line 27-30: The task captures
extension.pluginName.getOrElse(project.name) at configuration time (stored in
pluginName) which eagerly materializes the Property and breaks
configuration-cache; move resolution into the task action by passing the
Extension instance (or accessing the task's extension) inside the doLast/execute
block and call extension.pluginName.getOrElse(project.name) there, instead of
using the captured pluginName variable; similarly defer any use of
apkDir/outputDir that depends on pluginName by computing paths inside the action
so PluginBuilder's task action reads properties lazily.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 73bb60b3-dda5-4c91-9608-a9e14a66252a

📥 Commits

Reviewing files that changed from the base of the PR and between 99c02e8 and 38e62bc.

📒 Files selected for processing (1)

• plugin-api/plugin-builder/src/main/kotlin/com/itsaky/androidide/plugins/build/PluginBuilder.kt