Skip to content

ADFA-2455: remove debug logs from build output#1037

Merged
itsaky-adfa merged 6 commits intostagefrom
fix/ADFA-2455
Mar 5, 2026
Merged

ADFA-2455: remove debug logs from build output#1037
itsaky-adfa merged 6 commits intostagefrom
fix/ADFA-2455

Conversation

@itsaky-adfa
Copy link
Contributor

@itsaky-adfa itsaky-adfa commented Mar 4, 2026

See ADFA-2455 for more details.

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>
@itsaky-adfa itsaky-adfa requested a review from a team March 4, 2026 11:56
@itsaky-adfa itsaky-adfa self-assigned this Mar 4, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 4, 2026

📝 Walkthrough

Walkthrough

Formatting and logging adjustments across tooling, builder, and logging modules: minor Kotlin formatting changes, reduced/error→debug logging for tooling server streams, runtime feature-flag gating for tooling logging, and a runtime-configurable JVM stderr appender that can be disabled via system property.

Changes

Cohort / File(s) Summary
Project sync helper (formatting/logging)
subprojects/tooling-api/src/main/java/com/itsaky/androidide/tooling/api/sync/ProjectSyncHelper.kt
Whitespace/formatting and expression-body conversions; removed several debug log calls; trailing commas and minor string concatenation/indent tweaks. No signature or control-flow changes.
Tooling server / builder logging
app/src/main/java/com/itsaky/androidide/services/builder/GradleBuildService.kt, app/src/main/java/com/itsaky/androidide/services/builder/ToolingServerRunner.kt
Changed tooling-server error-stream line logging from ERROR→DEBUG; replaced compile-time constant with runtime feature flag (FeatureFlags.isDebugLoggingEnabled) to control tooling logging behavior.
JVM stderr appender runtime gating
logger/src/main/java/com/itsaky/androidide/logging/JvmStdErrAppender.java
Added runtime-enabled flag read from system property ide.logging.jvmStdErrAppenderEnabled combined with LogUtils.isJvm(); added append(ILoggingEvent) override that no-ops when disabled. Minor formatting changes and new import.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • jomen-adfa
  • jatezzz

Poem

🐇 I nibbled logs and smoothed the seam,
Trailing commas caught my dream,
Flags now whisper when to shout,
Stderr hushes — quiet about,
A rabbit hops, the code looks clean.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 62.50% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description references the related issue tracker ticket (ADFA-2455) and aligns with the PR's stated objective of removing debug logs from build output.
Title check ✅ Passed The title accurately reflects the main objective of the PR—removing debug logs from build output by changing logging levels and conditionally gating appender behavior.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/ADFA-2455

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@Daniel-ADFA Daniel-ADFA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>
Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>
Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>
@itsaky-adfa itsaky-adfa changed the title ADFA-2455: remove debug logs that shows up in build output ADFA-2455: remove debug logs from build output Mar 4, 2026
@itsaky-adfa itsaky-adfa merged commit b6d0e37 into stage Mar 5, 2026
2 checks passed
@itsaky-adfa itsaky-adfa deleted the fix/ADFA-2455 branch March 5, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants