[TE][CreatePrimFunc] Fix create reduce block with spatial iter dependent init value #17301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
approved these changes
Aug 23, 2024
wrongtest-intellif
force-pushed
the
fix_create_init_block_with_spatial_iter
branch
from
1a337d2 to
26117e9
Compare
wrongtest-intellif
changed the title
wrongtest-intellif
force-pushed
the
fix_create_init_block_with_spatial_iter
branch
from
26117e9 to
b899690
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing recursion for reduction's init value in
te.create_prim_funcRefer to https://discuss.tvm.apache.org/t/te-create-prim-func-vs-tvm-lower/17633
When the initial value depends on spatial iterators, we should also transform the initial value and remapping the vars.