[Relax][Analysis] Validate global_symbol on non-Relax functions #17203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I expect this PR to fail CI, as #17202 resolves a failure mode that this change is designed to detect. (Though that isn't necessarily the only case that this check will catch.) |
Prior to this commit, the well-formed checker verified that the `"global_symbol"` attribute, if present, matches the name of the `GlobalVar`. However, this check was only applied for Relax functions. As a result, discrepencies between the `"global_symbol"` and the `gvar->name_hint` could result in unexpected bugs. (For example, apache#17176.) This commit updates the well-formed checker to verify `"global_symbol"` on all functions in an `IRModule`.
Lunderberg
force-pushed
the
well_formed_global_symbol_on_all_ir_types
branch
from
afc68f4 to
ed94359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the well-formed checker verified that the
"global_symbol"attribute, if present, matches the name of theGlobalVar. However, this check was only applied for Relax functions. As a result, discrepencies between the"global_symbol"and thegvar->name_hintcould result in unexpected bugs. (For example, #17176.)This commit updates the well-formed checker to verify
"global_symbol"on all functions in anIRModule.