[Unity][Dlight][Fix] Reduction rule support dyn-shape epilogue #16429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a bug in the dlight reduction rule, which fails to recognize the pattern of a dynamic-shape epilogue block and therefore errors out when transforming such blocks. One regression test is provided.
MasterJH5574
force-pushed
the
unity-dev/2024-01-18-dlight-reduction-fix
branch
from
4cc6fdd to
1dafaac
Compare
MasterJH5574
added a commit
to mlc-ai/mlc-llm
that referenced
this pull request
Jan 20, 2024
With apache/tvm#16429 getting merged, we can enable all quantization tests for model compilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the dlight reduction rule, which fails to recognize the pattern of a dynamic-shape epilogue block and therefore errors out when transforming such blocks.
One regression test is provided.