[Unity][Transform] Use parameter name in BundleModelParams #16309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `BundleModelParams` would replace model parameters with `param_tuple[index]` within expressions. These nested expressions would then be normalized, resulting in `gv = param_tuple[index]` or `lv = param_tuple[index]` variable definitions. These auto-generated `gv` and `lv` names make it quite difficult to determine which model parameter is being used. This commit updates the `BundleModelParams` transform to explicitly produce the bound variable, `orig_param_name = param_tuple[index]`, preserving human-readable names from the parameters.
…16309 Pull in bugfix from apache#16322
slyubomirsky
approved these changes
Jan 8, 2024
Contributor
slyubomirsky
left a comment
slyubomirsky
left a comment
There was a problem hiding this comment.
Excellent quality-of-life improvement, thanks a ton.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
BundleModelParamswould replace model parameters withparam_tuple[index]within expressions. These nested expressions would then be normalized, resulting ingv = param_tuple[index]orlv = param_tuple[index]variable definitions. These auto-generatedgvandlvnames make it quite difficult to determine which model parameter is being used.This commit updates the
BundleModelParamstransform to explicitly produce the bound variable,orig_param_name = param_tuple[index], preserving human-readable names from the parameters.