[Unity][nnModule] Dynamic shape support in nn Module #16284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows dynamic shape in some modules of
nn.Module(Linear and Embedding), motivated by dynamic vocab size as discussed in mlc-ai/mlc-llm#1417.UX-wise
We allow
nn.Parameter("vocab_size", 4096), equivalent tonn.Parameter(tir.Var("vocab_size", "int64"), 4096).Symbolic relationship across Parameters
We make sure the same symbolic shape for different
nn.Parameterdo not appear twice within the same method. For instance, the following would not happen:This is prevented by
str2var_paramsinExporter, so that allembed_tokens.shape[0]andlm_head.shape[0]share the sametir.Var.Symbolic vars shared across functions
We also prevent two relax.Function sharing the same tir.Var for a symbolic shape, e.g. TIR variable A and B share the same physical address in memory below.
We prevent this by reinitializing
params = _params()and the mapping before each call to_emit_method(), so that thepacked_paramsis different for each function.