[Runtime] Introduce TVM_MODULE_VTABLE Macros
#16030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CC @Lunderberg @MasterJH5574 if you guys are interested |
junrushao
force-pushed
the
feature/2023-11-01/module-vtable
branch
4 times, most recently
from
c999b7f to
e34ccce
Compare
tqchen
approved these changes
Nov 1, 2023
This PR introduces a series of macros as part of TVM's
runtime::Module-based calling convention.
```C++
TVM_MODULE_VTABLE_BEGIN(TypeKey);
TVM_MODULE_VTABLE_ENTRY(Name, MemFunc);
TVM_MODULE_VTABLE_ENTRY_PACKED(Name, Func);
TVM_MODULE_VTABLE_END();
```
This way, one could conveniently define the callable symbols a TVM
Module exposes, for example, `runtime::relax_vm::Exectuable`, by
looking at the vtable below:
```C++
TVM_MODULE_VTABLE_BEGIN("VMExecutable"); // type key
TVM_MODULE_VTABLE_ENTRY("get_lib", &Executable::GetLib); // const member functions
...
TVM_MODULE_VTABLE_ENTRY_PACKED("vm_load_executable", Executable::Load); // non-member functions
TVM_MODULE_VTABLE_ENTRY("move_late_bound_consts", &Executable::MoveLateBoundConstantsToFile); // mutable member function
TVM_MODULE_VTABLE_END();
```
junrushao
force-pushed
the
feature/2023-11-01/module-vtable
branch
from
e34ccce to
a0c3edd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a series of macros as part of TVM's runtime::Module-based calling convention.
This way, one could conveniently define the callable symbols a TVM Module exposes, for example,
runtime::relax_vm::Exectuable, by looking at the vtable below: