[microNPU][ETHOSU] Fix ConcatRewriter args processing #16003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ConcatRewriter the case was not considered when the concatenation argument is TupleGetItem.
Aleksei-grovety
force-pushed
the
ethosu-fix-concat-rewriter
branch
from
656dd5d to
7de4d9a
Compare
ekalda
approved these changes
Oct 31, 2023
Contributor
ekalda
left a comment
ekalda
left a comment
There was a problem hiding this comment.
Thanks @Aleksei-grovety, LGTM!
Contributor
|
Thanks @Aleksei-grovety @ekalda! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ConcatRewriter the case was not considered when the concatenation argument is TupleGetItem.
cc @lhutton1, @ekalda, @leandron