-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[TensorIR][Visitor] Visit buffer members in match_buffer's in block visitor functions
#15153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
tqchen
approved these changes
Jun 24, 2023
match_buffer's in block visitor functions.match_buffer's in block visitor functions
Member
Author
|
@tvm-bot rerun |
junrushao
approved these changes
Jun 24, 2023
Member
Author
|
@tvm-bot rerun |
Member
Author
|
@tvm-bot rerun |
vinx13
added a commit
to vinx13/tvm
that referenced
this pull request
Sep 26, 2023
…in block visitor functions (apache#15153)" This reverts commit 34637d7.
vinx13
added a commit
to vinx13/tvm
that referenced
this pull request
Oct 17, 2023
…in block visitor functions (apache#15153) (apache#15816) * Revert "[TensorIR][Visitor] Visit buffer members in `match_buffer`'s in block visitor functions (apache#15153)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the
elem_offsetmember inmatch_buffer's will not be visited in default block visitor functions, resulting in some passes cannot correctly rewrite the program because some fields have not been entered.This PR fixes the issue by visiting this field in default StmtVisitor and StmtExpr.