[Frontend][Paddle] [PaddlePaddle Hackathon 4]add attribute support for gaussian_random/softplus/Conv3d/Conv2d #14801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Frontend][Paddle] [PaddlePaddle Hackathon 4]
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
jiangjiajun
suggested changes
May 10, 2023
| if x*beta <= threshold: | ||
| out = _op.log(_op.exp(x * beta) + _expr.const(1.0, dtype=dtype)) / beta | ||
| else: | ||
| out=x |
Contributor
There was a problem hiding this comment.
Please add test for this attribute
| input_data=input_data, | ||
| ) | ||
| verify_model(Conv3D(stride=2, padding="SAME", dilation=2, groups=3), input_data=input_data) | ||
| verify_model(Conv3D2(stride=2, padding="SAME", dilation=2, groups=3, data_layout='NHWC'), input_data=input_data) |
add test for softplus fix test for Conv3d
Contributor
|
Hi， @junrushao, Could you help to merge this PR? |
Member
|
Hi @jiangjiajun, I am happy to but seems that the linter fails at the moment. Please ping me after the PR passes CI :-) |
Contributor
check lint
check lint
check lint
check lint
check lint
check lint
check lint
Contributor
Author
|
@jiangjiajun Done. |
jiangjiajun
approved these changes
May 30, 2023
1.module 'paddle.nn.functional' has no attribute 'Softplus',change 'Softplus' to 'softplus' 2.test_forward_conv3d and test_forward_conv2d __init__() got an unexpected keyword argument 'data_layout',change 'data_layout' to 'data_format' 3.test_forward_gaussian_random verify_model() got an unexpected keyword argument 'shape',change 'shape' to 'input_data'
fix gpu CI error
fix gpu CI error
Contributor
Author
|
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
jiangjiajun
approved these changes
Jun 2, 2023
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jun 22, 2023
…r gaussian_random/softplus/Conv3d/Conv2d (apache#14801) * [Frontend][Paddle] [PaddlePaddle Hackathon 4] * Update test_forward.py * Update test_forward.py add test for softplus fix test for Conv3d * Update paddlepaddle.py check lint * Update test_forward.py check lint * Update paddlepaddle.py check lint * Update test_forward.py check lint * Update test_forward.py check lint * Update test_forward.py check lint * Update test_forward.py back * Update test_forward.py check lint * Update test_forward.py lint * trigger check again * fix gpu CI error 1.module 'paddle.nn.functional' has no attribute 'Softplus',change 'Softplus' to 'softplus' 2.test_forward_conv3d and test_forward_conv2d __init__() got an unexpected keyword argument 'data_layout',change 'data_layout' to 'data_format' 3.test_forward_gaussian_random verify_model() got an unexpected keyword argument 'shape',change 'shape' to 'input_data' * fix gpu CI error * fix softplus AssertionError * fix gpu CI error * fix gpu CI error * fix the "dtype" error of gaussian_random * fix gpu CI error of input_data of test_forward_gaussian_random * Update test_forward.py for gaussian_random CI * Update test_forward.py delete test_forward_gaussian_random
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add dtype attribute for gaussian_random op.
add threshold attribute for softplus op.
add data_format attribute for Conv3d/Conv2d op.