[CUDA] Fixed the call of the min function in the schedule for cuda #14751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
echuraev
reviewed
May 2, 2023
Contributor
echuraev
left a comment
echuraev
left a comment
There was a problem hiding this comment.
Could you please add an unit test?
echuraev
approved these changes
May 11, 2023
Contributor
echuraev
left a comment
echuraev
left a comment
There was a problem hiding this comment.
In general LGTM. Please remove redundant print.
tests/python/relay/test_any.py
Outdated
| continue | ||
| if kind == "debug" and (only_vm or dev.device_type != tvm.cpu().device_type): | ||
| continue | ||
| print(tgt) |
Contributor
There was a problem hiding this comment.
Do you really need this print?
Contributor
|
cc: @junrushao, @masahi |
Contributor
|
@tvm-bot rerun |
1 similar comment
Contributor
|
@tvm-bot rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a scatter layer for cuda target, it gives the following error:
ValueError: Cannot use and / or / not operator to Expr, hint: use tvm.tir.all / tvm.tir.any insteadThis is due to the call to the min function here:
tvm/python/tvm/topi/cuda/scatter.py
Lines 228 to 231 in d32dea8
This PR fixes this bug