THRIFT-5868: UUID Support for TCompactProtocol#3137
Closed
CJCombrink wants to merge 3 commits intoapache:masterfrom
Closed
THRIFT-5868: UUID Support for TCompactProtocol#3137CJCombrink wants to merge 3 commits intoapache:masterfrom
CJCombrink wants to merge 3 commits intoapache:masterfrom
Conversation
…alizedSize() - Fixes the issue with using a list of uuids in C++ - The T_UUID will always be 16 bytes long
- Add test for UUID in AllProtocolTests
Jens-G
pushed a commit
that referenced
this pull request
May 16, 2025
Client: cpp Patch: Carel Combrink This closes #3137
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add UUID support to the TCompactProtocol
Not only was this missing but also enables UUID tests in the AllProtocolTests
PS: This PR is from the same branch as #3136 thus the changes there are included in this PR and should dispensary if/when #3136 is merged
[skip ci]anywhere in the commit message to free up build resources.