Skip to content

remove unused writeUtf8 and readUtf8 from TProtocol.py#3123

Merged
fishy merged 2 commits intoapache:masterfrom
vzhd1701:patch-1
Apr 17, 2025
Merged

remove unused writeUtf8 and readUtf8 from TProtocol.py#3123
fishy merged 2 commits intoapache:masterfrom
vzhd1701:patch-1

Conversation

@vzhd1701
Copy link
Copy Markdown
Contributor

cleanup after #3105

writeUtf8 and readUtf8 are not referenced anywhere in the code any more

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@fishy fishy added the python label Apr 17, 2025
@fishy
Copy link
Copy Markdown
Member

fishy commented Apr 17, 2025

Can you please rebase on top of latest master branch so we can rerun CI? There was an issue with CI that's fixed in #3124.

@fishy fishy merged commit 4bacc1a into apache:master Apr 17, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants