Merged
Conversation
0287d82 to
6370cb0
Compare
ctubbsii
approved these changes
Aug 14, 2024
Member
|
It looks like that commit also broke something else which is fixed in https://github.com/apache/thrift/pull/3017/files#diff-dac985b5f3c62d122459132ffb79349f124eaf7f54eea6eba1d3b9d19b4d6a33R640-R644 |
Member
Author
Thanks. Since that PR is not merged yet, I'm going to incorporate that part of the fix into this PR instead. |
6370cb0 to
9d1ae4f
Compare
I think this was a bug from d4503a1. Co-Authored-By: Mario Emmenlauer <mario@emmenlauer.de>
9d1ae4f to
a1a1481
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this was a bug from d4503a1.
[skip ci]anywhere in the commit message to free up build resources.