Skip to content

Fix failed java build#3019

Merged
ctubbsii merged 2 commits intoapache:masterfrom
fishy:fix-java-build-failure
Aug 14, 2024
Merged

Fix failed java build#3019
ctubbsii merged 2 commits intoapache:masterfrom
fishy:fix-java-build-failure

Conversation

@fishy
Copy link
Copy Markdown
Member

@fishy fishy commented Aug 14, 2024

I think this was a bug from d4503a1.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@fishy fishy added the java Pull requests that update Java code label Aug 14, 2024
@fishy fishy requested a review from Jens-G August 14, 2024 16:33
@fishy fishy force-pushed the fix-java-build-failure branch from 0287d82 to 6370cb0 Compare August 14, 2024 17:40
@ctubbsii
Copy link
Copy Markdown
Member

It looks like that commit also broke something else which is fixed in https://github.com/apache/thrift/pull/3017/files#diff-dac985b5f3c62d122459132ffb79349f124eaf7f54eea6eba1d3b9d19b4d6a33R640-R644

@fishy
Copy link
Copy Markdown
Member Author

fishy commented Aug 14, 2024

It looks like that commit also broke something else which is fixed in https://github.com/apache/thrift/pull/3017/files#diff-dac985b5f3c62d122459132ffb79349f124eaf7f54eea6eba1d3b9d19b4d6a33R640-R644

Thanks. Since that PR is not merged yet, I'm going to incorporate that part of the fix into this PR instead.

@fishy fishy force-pushed the fix-java-build-failure branch from 6370cb0 to 9d1ae4f Compare August 14, 2024 20:31
I think this was a bug from d4503a1.

Co-Authored-By: Mario Emmenlauer <mario@emmenlauer.de>
@fishy fishy force-pushed the fix-java-build-failure branch from 9d1ae4f to a1a1481 Compare August 14, 2024 20:33
@fishy
Copy link
Copy Markdown
Member Author

fishy commented Aug 14, 2024

cc @emmenlau I listed you as co-author as you did the part of fix in 1a4bf78

@fishy fishy requested a review from emmenlau August 14, 2024 20:39
@ctubbsii ctubbsii merged commit a44c0c6 into apache:master Aug 14, 2024
@fishy fishy deleted the fix-java-build-failure branch August 14, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants