Conversation
|
@fishy is there anything i can run locally to test if the cross test will start? |
|
A later step for kotlin failed: https://github.com/apache/thrift/actions/runs/8294540230/job/22710000124?pr=2945
Not really, but you can look at the github action workflow definition and run the steps manually locally: thrift/.github/workflows/build.yml Line 192 in 0e72363 |
|
@fishy I fixed the kotlin compiler error, didnt realize this was re-using the java library 🙇 |
fishy
left a comment
fishy
left a comment
There was a problem hiding this comment.
looks good to me, but I'll give others more familiar with the java/kotlin code a chance to review before merging it.
in the mean time, @thomasbruggink can you please squash the commits?
Run `gradlew :spotlessApply` to apply the correct coding style. Update kotlin compiler to support `getEmptyResultInstance` apache#2939 added the feature to create an instance of the result object without having to use the ProcessFunction. The Kotlin compiler re-uses the java lib so this commit udpates the Kotlin compiler to support this feature as well.
thomasbruggink
force-pushed
the
fix-spotless-errors
branch
from
2fe855c to
bcad431
Compare
3 participants
Run
gradlew :spotlessApplyto apply the correct coding style.