THRIFT-5706: lib/cpp Fix the Security tests on openssl 1.1 and 3.0#2940
Merged
emmenlau merged 2 commits intoapache:masterfrom Aug 7, 2024
Merged
THRIFT-5706: lib/cpp Fix the Security tests on openssl 1.1 and 3.0#2940emmenlau merged 2 commits intoapache:masterfrom
emmenlau merged 2 commits intoapache:masterfrom
Conversation
5 tasks
thomasbruggink
force-pushed
the
fix-lib-cpp-security-tests
branch
from
19502bb to
8269092
Compare
This PR fixes the Security tests to build on a clean install of ubuntu 20.04 and ubuntu 22.04 without modifications to the systems openssl configuration. * Enable TLS 1.0 and TLS 1.1 on OpenSSL 1.1 with the seclevel=0 flag * Disable TLS 1.0 and TLS 1.1 on OpenSSL 3.0 While its technically possible to enable it on OpenSSL 3 I think because of all the issues with these old TLS versions dropping support for it is better. This PR builds forth on the work done here: apache#2811 Tested with the ubuntu 20.04 (OpenSSL 1.1) and 22.04 (OpenSSL 3.0) docker containers. All lib/cpp tests succeed in both.
thomasbruggink
force-pushed
the
fix-lib-cpp-security-tests
branch
from
8269092 to
8148f2f
Compare
Contributor
Author
|
@emmenlau any update on the review of this? |
Member
|
Sorry for the long delay! Looks good to me, lets bring this in! |
emmenlau
reviewed
Aug 7, 2024
Member
emmenlau
left a comment
emmenlau
left a comment
There was a problem hiding this comment.
I'm not sufficiently deep in the details of OpenSSL to know why these changes are correct. But they look thorough and to quite some extent self-explanatory. Also, I understand that tests have increased rather than decreased by the changes (see the changed check of openssl1 vs openssl3 at the end. Therefore: Looks good to me.
emmenlau
approved these changes
Aug 7, 2024
afuaide
pushed a commit
to afuaide/thrift
that referenced
this pull request
Aug 13, 2024
…ty-tests THRIFT-5706: lib/cpp Fix the Security tests on openssl 1.1 and 3.0
afuaide
pushed a commit
to afuaide/thrift
that referenced
this pull request
Aug 13, 2024
…ty-tests THRIFT-5706: lib/cpp Fix the Security tests on openssl 1.1 and 3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Security tests to build on a clean install of ubuntu
20.04 and ubuntu 22.04 without modifications to the systems openssl
configuration.
While its technically possible to enable it on OpenSSL 3 I think because
of all the issues with these old TLS versions dropping support for it is
better.
This PR builds forth on the work done here: #2811
Tested with the ubuntu 20.04 (OpenSSL 1.1) and 22.04 (OpenSSL 3.0) docker containers.
All lib/cpp tests succeed in both.