TEZ-4095: Review of Debug Logging#87
Merged
jteagles merged 2 commits intoapache:masterfrom Jan 20, 2021
Merged
Conversation
abstractdog
approved these changes
Jan 20, 2021
Contributor
abstractdog
left a comment
abstractdog
left a comment
There was a problem hiding this comment.
LGTM, all of @jteagles's comments were addressed here, could you please confirm?
jteagles
approved these changes
Jan 20, 2021
| ++numHeartbeats; | ||
| if (LOG.isDebugEnabled() || numHeartbeats % 50 == 1) { | ||
| LOG.info(constructPeriodicLog(freeResources)); | ||
| LOG.debug(constructPeriodicLog(freeResources)); |
Contributor
There was a problem hiding this comment.
This is a new change from the previous patch and a good catch that has been there since this file was created.
asfgit
pushed a commit
that referenced
this pull request
Jan 20, 2021
(cherry picked from commit c2d48a6)
Contributor
Author
|
@jteagles @abstractdog Thanks for the review (twice for @jteagles) and the merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying this again, albeit as a GitHub PR and, for simplicity, I tried to only "fix" debug statements that do not require much modification