TEZ-4647: Refactor plugin management from DAGAppMaster#428
Merged
abstractdog merged 2 commits intoapache:masterfrom Sep 15, 2025
Merged
TEZ-4647: Refactor plugin management from DAGAppMaster#428abstractdog merged 2 commits intoapache:masterfrom
abstractdog merged 2 commits intoapache:masterfrom
Conversation
abstractdog
force-pushed
the
TEZ-4647
branch
4 times, most recently
from
997d249 to
a38ec96
Compare
This comment was marked as outdated.
This comment was marked as outdated.
abstractdog
force-pushed
the
TEZ-4647
branch
from
a38ec96 to
b0d9e76
Compare
This comment was marked as outdated.
This comment was marked as outdated.
abstractdog
force-pushed
the
TEZ-4647
branch
from
b0d9e76 to
3070c74
Compare
This comment was marked as outdated.
This comment was marked as outdated.
abstractdog
force-pushed
the
TEZ-4647
branch
from
3070c74 to
fd835f1
Compare
abstractdog
force-pushed
the
TEZ-4647
branch
from
fd835f1 to
f0c4020
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
🎊 +1 overall
This message was automatically generated. |
ayushtkn
approved these changes
Sep 15, 2025
| public static void addDescriptor(List<NamedEntityDescriptor> list, BiMap<String, Integer> pluginMap, | ||
| NamedEntityDescriptor namedEntityDescriptor) { | ||
| list.add(namedEntityDescriptor); | ||
| pluginMap.put(list.get(list.size() - 1).getEntityName(), list.size() - 1); |
Member
There was a problem hiding this comment.
can do getLast instead of size -1
Contributor
Author
There was a problem hiding this comment.
yeah, absolutely
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
thanks @ayushtkn for the review, I'm merging this soon after addressing your comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Jira:
The proposal is to create a PluginManager to offload much of the plugin management code from the already overloaded DAGAppMaster class (including its static methods).
This issue was discovered while working on TEZ-4007, which only exacerbated the situation with the addition of AMExtensions (not AMExtensions themselves, but rather the original code in DAGAppMaster). Let’s clean this up first before proceeding with TEZ-4007.
Testing done with affected unit tests
mvn install -Dtest=TestTaskSchedulerManager,TestVertexImpl2,TestDAGAppMaster -pl ./tez-dag