TEZ-4624: Replace findbugs plugin with spotbugs

[maheshrajus]

TEZ-4624: Replace findbugs plugin with spotbugs

[tez-yetus]

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/1/console in case of problems.

[tez-yetus]

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/2/console in case of problems.

[tez-yetus]

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/3/console in case of problems.

[tez-yetus]

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/4/console in case of problems.

[tez-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	4m 11s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 1s		Shelldocs was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ master Compile Tests _
+0 🆗	mvndep	2m 38s		Maven dependency ordering for branch
+1 💚	mvninstall	9m 32s		master passed
+1 💚	compile	4m 18s		master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚	compile	3m 50s		master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚	checkstyle	2m 25s		master passed
+1 💚	javadoc	2m 42s		master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚	javadoc	2m 26s		master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
-1 ❌	spotbugs	0m 21s	/branch-spotbugs-tez-api.txt	tez-api in master failed.
-1 ❌	spotbugs	0m 20s	/branch-spotbugs-tez-runtime-internals.txt	tez-runtime-internals in master failed.
-1 ❌	spotbugs	0m 21s	/branch-spotbugs-tez-dag.txt	tez-dag in master failed.
-1 ❌	spotbugs	0m 20s	/branch-spotbugs-root.txt	root in master failed.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	5m 32s		the patch passed
+1 💚	codespell	1m 1s		No new issues.
+1 💚	compile	4m 18s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚	javac	4m 18s		the patch passed
+1 💚	compile	3m 51s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚	javac	3m 51s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 25s	/results-checkstyle-tez-api.txt	tez-api: The patch generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
-0 ⚠️	checkstyle	0m 53s	/results-checkstyle-root.txt	root: The patch generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
+1 💚	hadolint	0m 1s		No new issues.
+1 💚	shellcheck	0m 3s		No new issues.
+1 💚	javadoc	2m 35s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚	javadoc	2m 26s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚	spotbugs	10m 10s		the patch passed
			_ Other Tests _
+1 💚	unit	2m 23s		tez-api in the patch passed.
+1 💚	unit	1m 2s		tez-runtime-internals in the patch passed.
+1 💚	unit	5m 4s		tez-dag in the patch passed.
-1 ❌	unit	75m 39s	/patch-unit-root.txt	root in the patch failed.
+1 💚	asflicense	1m 46s		The patch does not generate ASF License warnings.
		154m 43s

Reason	Tests
Failed junit tests	tez.analyzer.TestAnalyzer

Subsystem	Report/Notes
Docker	ClientAPI=1.49 ServerAPI=1.49 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/4/artifact/out/Dockerfile
GITHUB PR	#410
Optional Tests	dupname asflicense codespell detsecrets hadolint shellcheck shelldocs javac javadoc unit xmllint compile spotbugs checkstyle
uname	Linux ff22024d2ddf 5.15.0-138-generic #148-Ubuntu SMP Fri Mar 14 19:05:48 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-410/src/.yetus/personality.sh
git revision	master / 97be6ab
Default Java	Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/4/testReport/
Max. process+thread count	1448 (vs. ulimit of 5500)
modules	C: tez-api tez-runtime-internals tez-dag . U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/4/console
versions	git=2.34.1 maven=3.6.3 hadolint=1.18.0-0-g76eee5c codespell=2.0.0 shellcheck=0.7.1
Powered by	Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

[tez-yetus]

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/5/console in case of problems.

[tez-yetus]

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/6/console in case of problems.

[tez-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ master Compile Tests _
+0 🆗	mvndep	2m 31s		Maven dependency ordering for branch
+1 💚	mvninstall	7m 49s		master passed
+1 💚	compile	2m 31s		master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚	compile	2m 22s		master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚	javadoc	1m 40s		master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚	javadoc	1m 34s		master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 37s		the patch passed
+1 💚	codespell	0m 35s		No new issues.
+1 💚	compile	2m 39s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚	javac	2m 39s		the patch passed
+1 💚	compile	2m 26s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚	javac	2m 26s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	hadolint	0m 2s		No new issues.
+1 💚	shellcheck	0m 2s		No new issues.
+1 💚	javadoc	1m 39s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚	javadoc	1m 24s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
			_ Other Tests _
+1 💚	unit	1m 59s		tez-api in the patch passed.
+1 💚	unit	0m 45s		tez-runtime-internals in the patch passed.
+1 💚	unit	4m 20s		tez-dag in the patch passed.
-1 ❌	unit	66m 33s	/patch-unit-root.txt	root in the patch failed.
+1 💚	asflicense	1m 18s		The patch does not generate ASF License warnings.
		109m 48s

Reason	Tests
Failed junit tests	tez.analyzer.TestAnalyzer

Subsystem	Report/Notes
Docker	ClientAPI=1.49 ServerAPI=1.49 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/6/artifact/out/Dockerfile
GITHUB PR	#410
Optional Tests	dupname asflicense codespell detsecrets hadolint shellcheck shelldocs javac javadoc unit xmllint compile
uname	Linux e1ea96ab52c8 5.15.0-136-generic #147-Ubuntu SMP Sat Mar 15 15:53:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-410/src/.yetus/personality.sh
git revision	master / eb876e3
Default Java	Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/6/testReport/
Max. process+thread count	2100 (vs. ulimit of 5500)
modules	C: tez-api tez-runtime-internals tez-dag . U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/6/console
versions	git=2.34.1 maven=3.6.3 hadolint=1.18.0-0-g76eee5c codespell=2.0.0 shellcheck=0.7.1
Powered by	Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

[tez-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 31s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ master Compile Tests _
+0 🆗	mvndep	2m 35s		Maven dependency ordering for branch
+1 💚	mvninstall	9m 40s		master passed
+1 💚	compile	4m 16s		master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚	compile	3m 50s		master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚	javadoc	2m 40s		master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚	javadoc	2m 29s		master passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for patch
+1 💚	mvninstall	7m 19s		the patch passed
+1 💚	codespell	1m 8s		No new issues.
+1 💚	compile	5m 18s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚	javac	5m 18s		the patch passed
+1 💚	compile	4m 24s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
+1 💚	javac	4m 24s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	hadolint	0m 2s		No new issues.
+1 💚	shellcheck	0m 4s		No new issues.
+1 💚	javadoc	2m 54s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04
+1 💚	javadoc	2m 37s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
			_ Other Tests _
+1 💚	unit	2m 22s		tez-api in the patch passed.
+1 💚	unit	0m 59s		tez-runtime-internals in the patch passed.
+1 💚	unit	5m 2s		tez-dag in the patch passed.
-1 ❌	unit	66m 54s	/patch-unit-root.txt	root in the patch failed.
+1 💚	asflicense	2m 15s		The patch does not generate ASF License warnings.
		129m 34s

Reason	Tests
Failed junit tests	tez.test.TestTezJobs

Subsystem	Report/Notes
Docker	ClientAPI=1.49 ServerAPI=1.49 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/5/artifact/out/Dockerfile
GITHUB PR	#410
Optional Tests	dupname asflicense codespell detsecrets hadolint shellcheck shelldocs javac javadoc unit xmllint compile
uname	Linux 014d9d382d1f 5.15.0-138-generic #148-Ubuntu SMP Fri Mar 14 19:05:48 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-410/src/.yetus/personality.sh
git revision	master / 1c39d80
Default Java	Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu122.04-b06
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/5/testReport/
Max. process+thread count	1147 (vs. ulimit of 5500)
modules	C: tez-api tez-runtime-internals tez-dag . U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/5/console
versions	git=2.34.1 maven=3.6.3 hadolint=1.18.0-0-g76eee5c codespell=2.0.0 shellcheck=0.7.1
Powered by	Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

[ayushtkn]

Looks f9 to me, maybe we can upgrade to the latest version, can you run spotbugs locally for all the modules & attach the result on the PR/ticket to show it isn't inducing any new issues

[abstractdog]

basically, looks good to me
please just update occurrences of "findbugs" in BUILDING.TXT

[maheshrajus]

basically, looks good to me please just update occurrences of "findbugs" in BUILDING.TXT

@abstractdog "findbugs" presented in 5 places in the file "BUILDING.TXT". In all places "findbugs" replaced by "spotbugs".

[maheshrajus]

@ayushtkn i generated the spotbugs report locally and comparing with old findbugs report(before spotbugs PR) and checking if there are any new issues generated by new rules added in spotbugs. If any issue that needs to fix or need to add exclude list will check and push. Thanks for the review !

[ayushtkn]

LGTM

[tez-yetus]

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/7/console in case of problems.

[maheshrajus]

Attaching spotbugs report which is run locally.
spotbugs-report.zip

[tez-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	27m 33s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ master Compile Tests _
+0 🆗	mvndep	2m 41s		Maven dependency ordering for branch
+1 💚	mvninstall	9m 34s		master passed
+1 💚	compile	4m 50s		master passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu122.04
+1 💚	compile	4m 24s		master passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu122.04-b09
+1 💚	checkstyle	2m 58s		master passed
+1 💚	javadoc	3m 12s		master passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu122.04
+1 💚	javadoc	2m 56s		master passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu122.04-b09
-1 ❌	spotbugs	0m 22s	/branch-spotbugs-tez-api.txt	tez-api in master failed.
-1 ❌	spotbugs	0m 20s	/branch-spotbugs-tez-runtime-internals.txt	tez-runtime-internals in master failed.
-1 ❌	spotbugs	0m 20s	/branch-spotbugs-tez-runtime-library.txt	tez-runtime-library in master failed.
-1 ❌	spotbugs	0m 20s	/branch-spotbugs-tez-dag.txt	tez-dag in master failed.
-1 ❌	spotbugs	0m 21s	/branch-spotbugs-root.txt	root in master failed.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	5m 56s		the patch passed
+1 💚	codespell	1m 1s		No new issues.
+1 💚	compile	4m 53s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu122.04
+1 💚	javac	4m 53s		the patch passed
+1 💚	compile	4m 23s		the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu122.04-b09
+1 💚	javac	4m 23s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	2m 41s		the patch passed
+1 💚	hadolint	0m 0s		No new issues.
+1 💚	shellcheck	0m 4s		No new issues.
+1 💚	javadoc	3m 6s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu122.04
+1 💚	javadoc	2m 56s		the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu122.04-b09
+1 💚	spotbugs	11m 20s		the patch passed
			_ Other Tests _
+1 💚	unit	2m 22s		tez-api in the patch passed.
+1 💚	unit	1m 0s		tez-runtime-internals in the patch passed.
+1 💚	unit	5m 44s		tez-runtime-library in the patch passed.
+1 💚	unit	5m 6s		tez-dag in the patch passed.
-1 ❌	unit	57m 56s	/patch-unit-root.txt	root in the patch failed.
+1 💚	asflicense	2m 7s		The patch does not generate ASF License warnings.
		173m 56s

Reason	Tests
Failed junit tests	tez.test.TestRecovery

Subsystem	Report/Notes
Docker	ClientAPI=1.49 ServerAPI=1.49 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/7/artifact/out/Dockerfile
GITHUB PR	#410
Optional Tests	dupname asflicense codespell detsecrets hadolint shellcheck shelldocs javac javadoc unit xmllint compile spotbugs checkstyle
uname	Linux bf381857926e 5.15.0-138-generic #148-Ubuntu SMP Fri Mar 14 19:05:48 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-410/src/.yetus/personality.sh
git revision	master / 850e5d0
Default Java	Private Build-1.8.0_452-8u452-gaus1-0ubuntu122.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-gaus1-0ubuntu122.04-b09
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/7/testReport/
Max. process+thread count	1159 (vs. ulimit of 5500)
modules	C: tez-api tez-runtime-internals tez-runtime-library tez-dag . U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-410/7/console
versions	git=2.34.1 maven=3.6.3 hadolint=1.18.0-0-g76eee5c codespell=2.0.0 shellcheck=0.7.1
Powered by	Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

[abstractdog]

the latest precommit still shows failures
I believe that regardless of local results, a spotbug should only fail if the newly introduced code in the PR contains problems, and the output should be obvious about that
I'm afraid we cannot merge the PR until we can reach that state

[maheshrajus]

@abstractdog @ayushtkn
today i fixed some spotbugs issues and some issues i put in exclude list due to this it run spotbugs for some submodules. For this submodules spotbugs failed with error "prefix spotbugs not found". For submodules spotbugs run with yetus it is not considering spotbugs changes due to this the error came. In local everything is working fine including submodules run and whole project spotbugs run.
Once spotbugs code is available in master branch then this problem will not exist. once spotbugs code is merged to master then i will rebase it with my open PR and check if any issue.

Spot bugs run and green when run for whole changes it is given +1. we can check this latest yetus precommit report.
+1 💚 | spotbugs | 11m 20s |   | the patch passed

Can i include only spotbug plugin changes in this PR ?
after merging the spotbugs changes then i will raise separate PR for the bug fixes and check if any issues.

[abstractdog]

thanks for the explanation, let's merge this and then open a dummy PR to check