TEZ-4388: Asynchttpclient can cause stuck TezChild processes#189
Merged
abstractdog merged 2 commits intoapache:masterfrom Feb 22, 2022
Merged
TEZ-4388: Asynchttpclient can cause stuck TezChild processes#189abstractdog merged 2 commits intoapache:masterfrom
abstractdog merged 2 commits intoapache:masterfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
could you review this @rbalamohan ? I'm hoping that you're still familiar with async http client |
Contributor
Author
|
I've just realized this patch NULLs out the static client and forces the next async http connection to create one...I'm not sure this is the perfect solution, let me investigate this further |
abstractdog
force-pushed
the
TEZ-4388
branch
from
4b87b79 to
7265e6c
Compare
abstractdog
changed the title
abstractdog
force-pushed
the
TEZ-4388
branch
from
7265e6c to
437de2b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
rbalamohan
reviewed
Feb 22, 2022
| TezRuntimeShutdownHandler.addShutdownTask(new Thread(() -> { | ||
| try { | ||
| if (httpAsyncClient != null) { | ||
| httpAsyncClient.close(); |
Contributor
There was a problem hiding this comment.
Should httpAsyncClient be set to "null" explicitly as well? Without it, it may create issues during container reuse. i.e httpAsyncClient will not be null, but in closed state & system would try to use it leading to exceptions.
abstractdog
force-pushed
the
TEZ-4388
branch
2 times, most recently
from
8ee557a to
27d3f7e
Compare
Contributor
|
LGTM. +1 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
abstractdog
force-pushed
the
TEZ-4388
branch
from
27d3f7e to
ad551af
Compare
|
💔 -1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Feb 22, 2022
…Laszlo Bodor reviewed by Rajesh Balamohan)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.