TEZ-4321: Do Not Wrap Singleton Collections#138
Merged
jteagles merged 1 commit intoapache:masterfrom Aug 9, 2021
Merged
Conversation
|
🎊 +1 overall
This message was automatically generated. |
|
+1. Good catch. |
jteagles
approved these changes
Aug 9, 2021
asfgit
pushed a commit
that referenced
this pull request
Aug 9, 2021
(cherry picked from commit f56075c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Singleton Collections are by their design immutable. There is no need to wrap them in an unmodifiableCollection.