This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-2130: Remove inet4 data type#1007
Closed
eminency wants to merge 13 commits intoapache:masterfrom
Closed
Conversation
* master: TAJO-2126: Allow parallel execution of non-leaf sibling ExecutionBlocks. TAJO-2127: Use Type instead of DataType for EvalNode. # Conflicts: # tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TypeConverter.java # tajo-core/src/main/java/org/apache/tajo/engine/codegen/TajoGeneratorAdapter.java # tajo-plan/src/main/java/org/apache/tajo/plan/verifier/ExprsVerifier.java
| returnType = TajoDataTypes.Type.TEXT, | ||
| paramTypes = {@ParamTypes(paramTypes = {Type.INET4})} | ||
| ) | ||
| public class GeoIPCountryInet4 extends GeneralFunction { |
Contributor
There was a problem hiding this comment.
I think these GeoIP function series are useful functions. It would be better to keep them by taking an INT4 type instead of INET4 type.
Contributor
Author
There was a problem hiding this comment.
Good suggestion, however IMO, it is a separated issue from removing the type.
What do you think about that?
Contributor
There was a problem hiding this comment.
I agree. It looks good to proceed this as an umbrella issue.
Would you create an umbrella ticket and some sub tasks on Jira?
* master: TAJO-2122: PullServer as an Auxiliary service of Yarn.
* master: TAJO-2110: Fix incorrect DateTime and remove hard coded tests. # Conflicts: # tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
Member
|
It seems to need to rebase. |
* master: TAJO-2129: Apply new type implementation to Schema and Catalog. Fix compilation error TAJO-1686: Allow Tajo to use Hive UDF. TAJO-2071: Supporting DATE type in Parquet format. TAJO-2145: Error codes based on errno.h need prefix. TAJO-2117: Add some missing index to MariaDBStore TAJO-2143: Fix race condition in task history writer. TAJO-2140: TajoInternalError does not contains reason stack trace. TAJO-2106: Fix minor typo in PostgreSQL Storage Handler documentation. TAJO-2142: Temporarily disable NOT IN subquery. TAJO-2135: Invalid join result when join key columns contain nulls. TAJO-2116: Simplify rpc address in default configuration. # Conflicts: # tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TypeConverter.java # tajo-common/src/main/java/org/apache/tajo/type/Inet4.java # tajo-common/src/main/java/org/apache/tajo/type/Type.java # tajo-core/src/main/java/org/apache/tajo/engine/codegen/TajoGeneratorAdapter.java # tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLAnalyzer.java # tajo-plan/src/main/java/org/apache/tajo/plan/verifier/ExprsVerifier.java # tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLLexer.g4 # tajo-sql-parser/src/main/antlr4/org/apache/tajo/parser/sql/SQLParser.g4 # tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/parquet/TajoRecordConverter.java # tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestStorages.java
Contributor
Author
|
@hyunsik , master branch is merged. @jihoonson , I created the issues you mentioned, TAJO-2155 and TAJO-2156. |
Contributor
|
+1 LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.