-
Notifications
You must be signed in to change notification settings - Fork 745
[GH-2552] Add ST_OrientedEnvelope #2553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| def ST_MinimumBoundingRadius(geometry: String): Column = | ||
| wrapExpression[ST_MinimumBoundingRadius](geometry) | ||
|
|
||
| def ST_OrientedEnvelope(geometry: Column): Column = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional tests added for scala
|
|
||
|
|
||
| @validate_argument_types | ||
| def ST_OrientedEnvelope(geometry: ColumnOrName) -> Column: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a test for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional tests added for python
| return circle; | ||
| } | ||
|
|
||
| public static Geometry orientedEnvelope(Geometry geometry) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mind also porting this to Flink and Snowflake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added Flink and Snowflake implementations
jiayuasu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Did you read the Contributor Guide?
Yes, I have read the Contributor Rules and Contributor Development Guide
Is this PR related to a ticket?
Yes, and the PR name follows the format
[SEDONA-XXX] my subject.What changes were proposed in this PR?
Implement
ST_OrientedEnvelopefunction by using JTSorg.locationtech.jts.algorithm.MinimumAreaRectangle.getMinimumRectangle()function.How was this patch tested?
Did this PR include necessary documentation updates?
vX.Y.Zformat.