[ISSUE #9984] Fix: slave delete all topic config and subGroup config when sync config from master#9996
Open
humkum wants to merge 1 commit intoapache:developfrom
Open
[ISSUE #9984] Fix: slave delete all topic config and subGroup config when sync config from master#9996humkum wants to merge 1 commit intoapache:developfrom
humkum wants to merge 1 commit intoapache:developfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9996 +/- ##
=============================================
- Coverage 48.85% 48.79% -0.06%
+ Complexity 12789 12771 -18
=============================================
Files 1327 1327
Lines 96441 96444 +3
Branches 12440 12442 +2
=============================================
- Hits 47115 47059 -56
- Misses 43586 43619 +33
- Partials 5740 5766 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RongtongJin
requested changes
Jan 8, 2026
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java
Show resolved
Hide resolved
RongtongJin
approved these changes
Jan 9, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9984
Brief Description
slave broker delete all topic config and subGroup config when sync meta data from master. The deletion operation should only be performed when the topic no longer exists on the master node and the corresponding deletion logic already exists.