Skip to content

[ISSUE # 10086] Fix timer engine switch to persist correct config key#10085

Merged
lizhimins merged 1 commit intoapache:developfrom
Liu-ZhenYu:fix/timer-rocksdb-enable-config
Feb 11, 2026
Merged

[ISSUE # 10086] Fix timer engine switch to persist correct config key#10085
lizhimins merged 1 commit intoapache:developfrom
Liu-ZhenYu:fix/timer-rocksdb-enable-config

Conversation

@Liu-ZhenYu
Copy link
Contributor

Motivation
switchTimerEngine writes timerUseRocksDB to the broker configuration, but the actual config key is timerRocksDBEnable. As a result, the switch isn’t persisted and may revert after restart.There’s also a typo in the error message.

Changes

  • Persist timerRocksDBEnable instead of timerUseRocksDB
  • Fix typo in error message (muse → must) and reference correct key name

Impact
Ensures engine switch is persisted correctly and improves user-facing guidance.

Test Plan

  • Manual: switch to RocksDB engine, verify timerRocksDBEnable=true is written to config; restart broker and confirm RocksDB engine remains enabled.

@Liu-ZhenYu Liu-ZhenYu changed the title Fix timer engine switch to persist correct config key [ISSUE # 10086] Fix timer engine switch to persist correct config key Feb 10, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.86%. Comparing base (ec7db8d) to head (56de824).

Files with missing lines Patch % Lines
...ocketmq/broker/processor/AdminBrokerProcessor.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10085      +/-   ##
=============================================
- Coverage      48.91%   48.86%   -0.06%     
+ Complexity     13364    13351      -13     
=============================================
  Files           1373     1373              
  Lines          99868    99868              
  Branches       12903    12903              
=============================================
- Hits           48855    48798      -57     
- Misses         45097    45148      +51     
- Partials        5916     5922       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Liu-ZhenYu Liu-ZhenYu requested a review from lizhimins February 11, 2026 04:47
@lizhimins lizhimins merged commit a6be1ee into apache:develop Feb 11, 2026
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants