[ISSUE # 10086] Fix timer engine switch to persist correct config key#10085
Merged
lizhimins merged 1 commit intoapache:developfrom Feb 11, 2026
Merged
Conversation
Open
3 tasks
RongtongJin
approved these changes
Feb 11, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10085 +/- ##
=============================================
- Coverage 48.91% 48.86% -0.06%
+ Complexity 13364 13351 -13
=============================================
Files 1373 1373
Lines 99868 99868
Branches 12903 12903
=============================================
- Hits 48855 48798 -57
- Misses 45097 45148 +51
- Partials 5916 5922 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lizhimins
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
switchTimerEngine writes timerUseRocksDB to the broker configuration, but the actual config key is timerRocksDBEnable. As a result, the switch isn’t persisted and may revert after restart.There’s also a typo in the error message.
Changes
Impact
Ensures engine switch is persisted correctly and improves user-facing guidance.
Test Plan