[ISSUE #10013] Prevent AsyncLearner from being elected as Master during initialization#10014
Open
1782935682 wants to merge 1 commit intoapache:developfrom
Open
[ISSUE #10013] Prevent AsyncLearner from being elected as Master during initialization#100141782935682 wants to merge 1 commit intoapache:developfrom
1782935682 wants to merge 1 commit intoapache:developfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10014 +/- ##
=============================================
- Coverage 48.81% 48.79% -0.02%
- Complexity 12763 12779 +16
=============================================
Files 1324 1327 +3
Lines 96407 96554 +147
Branches 12435 12458 +23
=============================================
+ Hits 47064 47118 +54
- Misses 43600 43667 +67
- Partials 5743 5769 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #10013
Brief Description
AsyncLearner nodes are designed as read-only backups and should never assume the Master role. Currently, if an AsyncLearner starts and registers before other nodes, it triggers the election process and becomes Master.
In the brokerElect() method: