[fix][client] Fail messages immediately in ProducerImpl when in terminal state#25317
Open
merlimat wants to merge 2 commits intoapache:masterfrom
Open
[fix][client] Fail messages immediately in ProducerImpl when in terminal state#25317merlimat wants to merge 2 commits intoapache:masterfrom
merlimat wants to merge 2 commits intoapache:masterfrom
Conversation
…nal state When a producer reaches a terminal state (Terminated, Closed, or ProducerFenced), messages entering processOpSendMsg() would be added to pendingMessages with no connection to write them, leaving them stuck until sendTimeout (default 30s). Add a terminal state check in processOpSendMsg() before adding to the pending queue, failing the message immediately with the appropriate exception. Also fix testTerminateWhilePublishing to close the producer after termination, since the broker's CommandCloseProducer races with CommandSendError responses, preventing the client from learning about topic termination through the normal error path.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #25317 +/- ##
==========================================
Coverage 72.66% 72.66%
+ Complexity 34651 34244 -407
==========================================
Files 1967 1967
Lines 156326 156342 +16
Branches 17812 17813 +1
==========================================
+ Hits 113591 113612 +21
+ Misses 33671 33638 -33
- Partials 9064 9092 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a producer reaches a terminal state (Terminated, Closed, or ProducerFenced), messages entering processOpSendMsg() would be added to pendingMessages with no connection to write them, leaving them stuck until sendTimeout (default 30s).
Add a terminal state check in processOpSendMsg() before adding to the pending queue, failing the message immediately with the appropriate exception. Also fix testTerminateWhilePublishing to close the producer after termination, since the broker's CommandCloseProducer races with CommandSendError responses, preventing the client from learning about topic termination through the normal error path.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: