Merged
Conversation
mapleFU
approved these changes
Aug 13, 2024
wgtmac
approved these changes
Aug 14, 2024
pitrou
reviewed
Aug 14, 2024
bad_data/README.md
Outdated
|
|
||
| * PARQUET-1481.parquet: tests a case where a schema Thrift value has been | ||
| corrupted | ||
| * arrow_issue_41321.parquet: test case of https://github.com/apache/arrow/issues/41321 |
Member
There was a problem hiding this comment.
Maybe try to unify the file naming in this directory? We already have PARQUET-1481.parquet (a JIRA reference) so perhaps something like ARROW-GH-41321.parquet? (related: #57)
Member
|
I would merge this in 1 day if no negative comment. 7.1k is a bit large here but it's not too large since generate a file like this is also hard. |
pitrou
approved these changes
Aug 15, 2024
Member
|
Merged! Thanks all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those 2 files triggered libparquet c++ issues apache/arrow#41317 and apache/arrow#41321 . They have been generated through a local run of oss-fuzz on synthetic test data of the GDAL regression test suite, and can be licensed under Apache-2