CI: the final migration

[mbien]

continues finishes the great migration (#4431).

• second attempt to migrate the groovy jobs (first: migrate groovy ci matrix from travis to gh actions. #4105). I have the suspicion that the tests can't run on anything > JDK 8. The test setup on travis is just testing the same thing three times in a matrix. This comment made a similar observation. -> going to leave the groovy tests on 8 for now.
• migrated harness, ergonomics, nb modules and merged them into a single job
• can't get the LSP tests to run so far (update: Test bugfixes: preparation for GH action migration #4975)
• going to migrate the rest too since apache will end travis support end of this year

new labels to control jobs with:

• Groovy runs the groovy job
• GraalVM runs the GraalVM job - should this trigger on other labels too?
• LSP runs the LSP (server) job, client is currently tested via the IDE job
• VSCode Extension runs the VSCode job
• tests enables a step which builds all tests, this will only run on PRs, not on the master branch
• list of all ci labels including the new ones

Harness job runs with the Platform label - haven't found a better place to put it.

Each commit usually migrates a single job to make review easier.

The last commit adds some general improvements:

• mac runners have ant installed, brew/cache isn't needed anymore.
• added cache for platform-src build
• bump JDK version of migrated jobs to 11 where possible
• extract java distribution variable
• increase pipeline artifact retention time from 1 to 2 days
• added per-job timeouts (at least 2x of average runtime; 1h minimum)
• always run the paperwork job
• set continue-on-error for java.mx.project false in PRs
• wrapped platform/core.startup, java/java.editor and java.lsp.server in retry script
• ci:dev-build will now produce a dev-build zip artifact
• setup all JDKs at the start of the job for consistent timestamp

NB can now also build on JDK 19:

• build matrix is now 11, 17 and 19
• gradle daemon will run on JDK 11

[neilcsmith-net]

Well, this puts a timescale of end of year on all this - https://cwiki.apache.org/confluence/pages/viewpage.action?spaceKey=INFRA&title=Travis+Migrations

[mbien]

yes I saw the mail too. Good that we started so early - the hardest part is done :)

[mbien]

@matthiasblaesing I noticed that you are sometimes providing dev builds for your PRs to make it easier to review. I added a label activated dev build step which can do the same (ci:dev-build). Would this be useful for you?

a test run is here (scroll down):
https://github.com/apache/netbeans/actions/runs/3491385341

retention time is set to 7 days. Its a zip in a zip but this is currently a github limitation.

[mbien]

@neilcsmith-net @ebarboni (or anybody else)
Can we skip the gen-sigtests step sometimes? Should I add it to a label or something similar? Check-sigtests is important but I believe the gen step is just useful for regression testing.
https://github.com/apache/netbeans/actions/runs/3491385341/jobs/5844321726

edit: sorry made a typo and pinged Eirik by accident. Hello Eirik :)

#4817 (comment)

@neilcsmith-net I added the build-from-platform-source-zip job as step to platform batch1 job
https://github.com/apache/netbeans/actions/runs/3491385341/jobs/5844322212#step:48:1

I am going to try to enable caching with the next update so that the build won't download dependencies again.

[mbien]

LSP job sometimes errors with:

[junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec
[junit] 
[junit] Testcase: org.netbeans.modules.java.lsp.server.protocol.ServerTest:testDidOpenPreservesLines:	Caused an ERROR
[junit] Timeout occurred. Please note the time in the report does not reflect the time until the timeout.
[junit] junit.framework.AssertionFailedError: Timeout occurred. Please note the time in the report does not reflect the time until the timeout.
[junit] 	at java.util.Vector.forEach(Vector.java:1277)
[junit] 	at java.util.Vector.forEach(Vector.java:1277)
[junit] 
[junit] 
[junit] Test org.netbeans.modules.java.lsp.server.protocol.ServerTest FAILED (timeout)

but the retry script can brute force through it - so its all good.

Thanks to @sdedic for fixing the nb-javac task issue in #4975 (#4921 for context). I also changed all jobs which use multiple JDKs to set them up right at the beginning of the job for getting consistent timestamps of JDK tools.

[mbien]

@neilcsmith-net @lkishalmi @ebarboni @sdedic would now be a good time to merge this? Is most of the release work done? I also see master is green again.. so this might be good timing.

Reminder that travis will be gone in less than a month. We should have CI working before that so that we can fix things if needed.

[ebarboni]

I would say go for it.

[neilcsmith-net]

Agree with @ebarboni - let's go! Also, while we're not doing branch protection on checks, a reminder on list that from now on CI should be expected to be green before merging wouldn't be amiss.

Thanks for all your work on this!