Implement node status synchronization in Controller, including downtime notifications and online/offline management#388
Open
Paragrf wants to merge 2 commits intoapache:unstablefrom
Open
Implement node status synchronization in Controller, including downtime notifications and online/offline management#388Paragrf wants to merge 2 commits intoapache:unstablefrom
Paragrf wants to merge 2 commits intoapache:unstablefrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #388 +/- ##
============================================
+ Coverage 43.38% 50.09% +6.70%
============================================
Files 37 45 +8
Lines 2971 3885 +914
============================================
+ Hits 1289 1946 +657
- Misses 1544 1724 +180
- Partials 138 215 +77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
git-hulk
reviewed
Apr 20, 2026
| ErrShardIsServicing = errors.New("shard is servicing") | ||
| ErrShardSlotIsMigrating = errors.New("shard slot is migrating") | ||
| ErrShardNoMatchNewMaster = errors.New("no match new master in shard") | ||
| ErrCannotOfflineMaster = errors.New("cannot take master node offline, failover first") |
Member
There was a problem hiding this comment.
Suggested change
| ErrCannotOfflineMaster = errors.New("cannot take master node offline, failover first") | |
| ErrCannotOfflineMaster = errors.New("cannot offline the master node offline") |
| role string | ||
| password string | ||
| createdAt int64 | ||
| failed bool |
Member
There was a problem hiding this comment.
Could we change failed to status? so that we can add more statuses in future
Comment on lines
+183
to
+214
| func (cluster *Cluster) SetNodesOffline(addrs []string) error { | ||
| nodes := make([]Node, 0, len(addrs)) | ||
| for _, addr := range addrs { | ||
| node := cluster.findNodeByAddr(addr) | ||
| if node == nil { | ||
| return fmt.Errorf("node %s: %w", addr, consts.ErrNotFound) | ||
| } | ||
| if node.IsMaster() { | ||
| return fmt.Errorf("node %s: %w", addr, consts.ErrCannotOfflineMaster) | ||
| } | ||
| nodes = append(nodes, node) | ||
| } | ||
| for _, node := range nodes { | ||
| node.SetFailed(true) | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (cluster *Cluster) SetNodesOnline(addrs []string) error { | ||
| nodes := make([]Node, 0, len(addrs)) | ||
| for _, addr := range addrs { | ||
| node := cluster.findNodeByAddr(addr) | ||
| if node == nil { | ||
| return fmt.Errorf("node %s: %w", addr, consts.ErrNotFound) | ||
| } | ||
| nodes = append(nodes, node) | ||
| } | ||
| for _, node := range nodes { | ||
| node.SetFailed(false) | ||
| } | ||
| return nil | ||
| } |
Member
There was a problem hiding this comment.
Can merge them into SetNodeStatusByAddr
| return nil | ||
| } | ||
|
|
||
| func (cluster *Cluster) SetNodeFailedByID(nodeID string, failed bool) error { |
Member
There was a problem hiding this comment.
Can change to SetNodeStatusByID
Member
|
@Paragrf Sorry for the late review due to the heavy traffic at work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
To improve cluster reliability and operational efficiency, the controller needs to bridge the status gap between slave nodes and the server. Beyond just reporting unexpected failures, it is essential to support proactive maintenance workflows, allowing operators to safely remove traffic before performing node updates or hardware swaps.
Key Changes
Downtime Push: The controller now monitors slave node health and proactively pushes "Downtime" alerts to the server upon detection of a crash or heartbeat timeout.
Manual Offline (Traffic Draining): Supports a proactive "Offline" command. This allows the server to drain/stop traffic to a specific slave node before any maintenance work begins, ensuring zero-impact operations.
Manual Online: Supports a "Ready-to-Serve" notification when a slave is back online and fully synchronized, allowing the server to safely re-enable traffic.
Related Issues
Fixes #385