Skip to content

Conversation

@DL1231
Copy link
Collaborator

@DL1231 DL1231 commented Dec 15, 2025

This PR distinguishes between RemoteStorageException and
RetriableRemoteStorageException in RemoteLogManager to handle
temporary storage degradations gracefully:

  1. Copy path: Avoids deleting partially uploaded segments when
    RetriableRemoteStorageException is thrown;
  2. Delete path: Skips incrementing failedRemoteDeleteRequestRate metric
    for retriable exceptions;
  3. Documentation: Updates RemoteStorageManager Javadoc to clarify
    exception usage;
  4. Testing: Adds UT for retriable scenarios.

@github-actions github-actions bot added triage PRs from the community storage Pull requests that target the storage module tiered-storage Related to the Tiered Storage feature labels Dec 15, 2025
@DL1231 DL1231 requested a review from kamalcph December 15, 2025 07:43
Copy link
Contributor

@kamalcph kamalcph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! It looks good to me.

We can further update the RemoteLogManager javadoc to convey the contract to the plugin implementor.

@showuon Could you also review this PR? More details are on the ticket: KAFKA-19981. We want to take different actions in Kafka based on the error thrown by the plugin. Let me know your thoughts. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

storage Pull requests that target the storage module tiered-storage Related to the Tiered Storage feature triage PRs from the community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants